User: starksm 
  Date: 02/02/05 10:59:04

  Modified:    src/main/org/jboss/security/auth/spi Tag: Branch_2_4
                        UsersRolesLoginModule.java
  Log:
  Fix problem with role assignment with users have a common
  prefix in their username. Bug #513245
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.6.4.2   +8 -5      
jbosssx/src/main/org/jboss/security/auth/spi/UsersRolesLoginModule.java
  
  Index: UsersRolesLoginModule.java
  ===================================================================
  RCS file: 
/cvsroot/jboss/jbosssx/src/main/org/jboss/security/auth/spi/UsersRolesLoginModule.java,v
  retrieving revision 1.6.4.1
  retrieving revision 1.6.4.2
  diff -u -r1.6.4.1 -r1.6.4.2
  --- UsersRolesLoginModule.java        2001/10/19 23:50:08     1.6.4.1
  +++ UsersRolesLoginModule.java        2002/02/05 18:59:04     1.6.4.2
  @@ -127,12 +127,15 @@
               String value = roles.getProperty(user);
               // See if this entry is of the form targetUser[.GroupName]=roles
               int index = user.indexOf('.');
  -            int length = index > 0 ? index : user.length();
  -            if( targetUser.regionMatches(0, user, 0, length) == false )
  -                continue;
  +            boolean isRoleGroup = false;
  +            boolean userMatch = false;
  +            if( index > 0 && targetUser.regionMatches(0, user, 0, index) == true )
  +                isRoleGroup = true;
  +            else
  +               userMatch = targetUser.equals(user);
   
               // Check for username.RoleGroup pattern
  -            if( index > 0 )
  +            if( isRoleGroup == true )
               {
                   String groupName = user.substring(index+1);
                   if( groupName.equals("Roles") )
  @@ -144,7 +147,7 @@
                       groups.add(group);
                   }
               }
  -            else
  +            else if( userMatch == true )
               {
                   // Place these roles into the Default "Roles" group
                   parseGroupMembers(rolesGroup, value);
  
  
  

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to