User: patriot1burke
Date: 02/02/21 13:45:18
Modified: src/main/org/jboss/ejb/plugins Tag: Branch_2_4
AbstractInstanceCache.java
Log:
do not obtain a reference to the BeanLock on a get. Causes memory leaks and problems
Revision Changes Path
No revision
No revision
1.10.2.8 +1 -8 jboss/src/main/org/jboss/ejb/plugins/AbstractInstanceCache.java
Index: AbstractInstanceCache.java
===================================================================
RCS file:
/cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/AbstractInstanceCache.java,v
retrieving revision 1.10.2.7
retrieving revision 1.10.2.8
diff -u -r1.10.2.7 -r1.10.2.8
--- AbstractInstanceCache.java 17 Jan 2002 17:39:35 -0000 1.10.2.7
+++ AbstractInstanceCache.java 21 Feb 2002 21:45:17 -0000 1.10.2.8
@@ -64,7 +64,7 @@
* @author <a href="[EMAIL PROTECTED]">Marc Fleury</a>
* @author <a href="[EMAIL PROTECTED]">Scott Stark</a>
*
- * @version $Revision: 1.10.2.7 $
+ * @version $Revision: 1.10.2.8 $
*
* <p><b>Revisions:</b>
*
@@ -268,9 +268,6 @@
// run without having acquired the cache lock via getCacheLock()
throw new IllegalStateException("INSERTING AN ALREADY EXISTING BEAN, ID
= " + key);
}
- //Create a lock in the lock manager, as long as there an instance in cache
we keep
- // the lock in the manager, since get will increase the ref count on the
lock
- getContainer().getLockManager().getLock(key);
}
}
/* From InstanceCache interface */
@@ -287,7 +284,6 @@
if (getCache().peek(id) != null)
{
getCache().remove(id);
- getContainer().getLockManager().removeLockRef(id);
}
// This call, executed anyway, leaves door open to multiple scheduling
// of the same context, which I take care in other places, in
@@ -307,9 +303,6 @@
if (getCache().peek(id) != null)
{
getCache().remove(id);
- // When we introduced the bean in the cache we used the get to increase
the lock count
- // now we decrease it and if the count is zero the manager will release
the object from memory
- getContainer().getLockManager().removeLockRef(id);
}
}
}
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
