The main problem with using ../ here (and other places) is that when the
configuration as specified on the command line changes, this breaks.
It would be better to be explit here, and other places which need
configuration directories or urls to use the values determined by
ServerConfig* by using the system properties which it sets.
If we change ServiceConfigurator to handle this, then we can reduce some
code duplication as target components won't have to deal with prepending
base bases to relative ones.
Relying on ../ in configuration or code is a poor choice when we can
make use of the exposed configuration.
--jason
Hiram Chirino wrote:
> it would be kinda nice if the url's in the service.xml file were
> relative to the service.xml file. Do I make sense?? so if the
> service.xml files is:
> /jboss/server/default/deploy/jbossmq-service.xml
> To load all the jboss/lib jars :
> <classpath codebase="../../../../lib" archives="*"/>
> To load all the jars in the server's lib dirctory:
> /jboss/server/default/lib
> <classpath codebase="../lib" archives="*"/>
>
> Regards,
> Hiram
>
>> From: Jason Dillon <[EMAIL PROTECTED]>
>> To: David Jencks <[EMAIL PROTECTED]>
>> CC: [EMAIL PROTECTED]
>> Subject: Re: [JBoss-dev] Property access in *service.xml and relative
>> paths
>> Date: Thu, 28 Feb 2002 19:51:32 -0800
>>
>> I sent mail on this before I commited the layout change. It has todo
>> with which directory/url do we use to qualify relative paths. It also
>> has todo with allow a global and per-server config library directory.
>>
>> --jason
>>
>>
>> David Jencks wrote:
>>
>>> On 2002.02.28 22:35:27 -0500 Jason Dillon wrote:
>>>
>>>> I was thinking that a solution to the problem that MD now has due
>>>> to the
>>>> layout changes that I made WRT relatives paths could be solved by
>>>> forcing users to be explicit about which path they which to use
>>>> (ie. not
>>>> allowing relative paths).
>>>>
>>>
>>> What are these problems? I haven't noticed any. Using <classpath
>>> .../> can
>>> cause problems, but it is almost always better to just leave the tag
>>> out.
>>>
>>> david jencks
>>>
>>>
>>>> To make this work we need to expose some system property access inside
>>>> of the *service.xml files... probably as an attribute value subst
>>>> and an
>>>> element... for example:
>>>>
>>>> <!-- this is everything under jboss-*/lib -->
>>>> <classpath codebase="${jboss.home.dir}/lib" archives="*"/>
>>>>
>>>> <!-- This is everything under jboss-*/server/<config>/lib -->
>>>> <classpath codebase="${jboss.server.home.dir}/lib" archives="*"/>
>>>>
>>>> <!-- This would set the MyConfigName attribute to the servers config
>>>> name.
>>>> <attribute name="MyConfigName">
>>>> <property name="jboss.server.name"/>
>>>> </attribute>
>>>>
>>>> Could also expose a element ot set a property:
>>>>
>>>> <!-- Set a property myprop to some value -->
>>>> <setproperty name="myprop" value="somevalue"/>
>>>>
>>>> Which could then be used in config elements later in the file...
>>>>
>>>> And to finally solve the two lib problem... just more than one
>>>> classpath
>>>> (if that isn't the case already):
>>>>
>>>> <classpath codebase="${jboss.server.home.dir}/lib" archives="*"/>
>>>> <classpath codebase="${jboss.home.dir}/lib" archives="*"/>
>>>>
>>>> This would prefer libs from inside jboss.server.home.dir/lib before
>>>> jboss.home.dir/lib
>>>>
>>>> --jason
>>>>
>>>>
>>>> _______________________________________________
>>>> Jboss-development mailing list
>>>> [EMAIL PROTECTED]
>>>> https://lists.sourceforge.net/lists/listinfo/jboss-development
>>>>
>>>>
>>
>>
>>
>> _______________________________________________
>> Jboss-development mailing list
>> [EMAIL PROTECTED]
>> https://lists.sourceforge.net/lists/listinfo/jboss-development
>
>
>
>
>
> _________________________________________________________________
> Get your FREE download of MSN Explorer at
> http://explorer.msn.com/intl.asp.;
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development