IMO we either need to create every jsr-77 mbean in the init phase of the
appropriate deployer or deployment activity, or create the jsr-77 mbeans in
create and set their parents in start.  We also need to deal with jsr-77
mbeans for non-j2ee packages such as sars, and non-j2ee nesting such as ear
in ear or ear in ejb-jar.  These will deploy just fine except for the
jsr-77 stuff.

The current setup will not work for ejb-jar in ejb-jar, for 2 reasons:

1. same problem you fixed here, inside create called first.

2. jsr-77 stuff doesn't expect this (non j2ee) nesting.

david jencks


On 2002.03.02 18:22:10 -0500 Adrian Brock wrote:
>   User: ejort   
>   Date: 02/03/02 15:22:10
> 
>   Modified:    src/main/org/jboss/deployment EARDeployer.java
>   Log:
>   Create the JSR77 appliction in init. Sub-module creation comes before
> application creation. The sub-modules JSR77 mbeans need the application
> mbean to exist
>   
>   Revision  Changes    Path
>   1.10      +9 -10     jboss/src/main/org/jboss/deployment/EARDeployer.java
>   
>   Index: EARDeployer.java
>   ===================================================================
>   RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/deployment/EARDeployer.java,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- EARDeployer.java        2 Mar 2002 16:34:25 -0000       1.9
>   +++ EARDeployer.java        2 Mar 2002 23:22:10 -0000       1.10
>   @@ -49,7 +49,7 @@
>    /**
>    *
>    * @author <a href="mailto:[EMAIL PROTECTED]";>Marc Fleury</a>
>   -* @version $Revision: 1.9 $
>   +* @version $Revision: 1.10 $
>    */
>    public class EARDeployer
>    extends ServiceMBeanSupport
>   @@ -130,21 +130,20 @@
>             log.error("Error in init step of ear deployment", e);
>             throw new DeploymentException("Error in accessing application
> metadata: ", e);
>          }
>   -      
>   +      // Create the appropriate JSR-77 instance, this has to be done
> in init
>   +      // EAR create is called after sub-component creates that need
> this MBean
>   +      ObjectName lApplication = J2EEApplication.create(
>   +         server,
>   +         di.shortName,
>   +         di.localUrl
>   +      );
>       }
>       
>       
>       public void create(DeploymentInfo di)
>          throws DeploymentException
>       {
>   -      // now try to deploy
>   -      log.info("Deploying J2EE application, create step: " + di.url);
>   -      // Create the appropriate JSR-77 instance
>   -      ObjectName lApplication = J2EEApplication.create(
>   -         server,
>   -         di.shortName,
>   -         di.localUrl
>   -      );
>   +      log.info("Deploying J2EE application, create step, a no-op: " +
> di.url);
>       }
>       
>       public void start(DeploymentInfo di)
>   
>   
>   
> 
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/jboss-development
> 
> 

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to