So all of the examples you list which depend on other modules to function are integration tests. You could imagine that for Naming you might have a simple test which only tests the basic protocol handshaking, versioning or whatever. For transactions you might have a simple test to make sure that the UserTransaction class functions as expected. I can't think of an example of security... 'cause don't really know anything about it.
My point is that most of our tests cover a vary large area. A single test might hit deployment, ejb container startup, jndi proxy factory lookup, factory creation, proxy invocation. I agree that these tests are very important and needed, but what about testing each of these steps in isolation? This would help detect finer grained problems faster and provide better coverage overall. That is one point, the second is where those tests should go. I believe they should be closer to the code which they are testing, rather than put into a monolithic testsuite module. BUT this is only for tests as I mention above, which only test the components. One reason for this is for modules which span projects, the core testsuite for the code will move with it, rather than have to pick apart jboss/testsuite for the correct bits. This is an organizational concept, where module test code stays with the module, where tests which cover more than one module live in the testsuite module. Take the jboss/common module. This module depends on nothing. There are many classes here which could benefit from simple tests to validate the functionality of the code which resides here. These classes are also used through-out the entire server, so they will also be tested by other tests as well. That does not mean that they are better suited to live in the testsuite module. As it stands right now, the testsuite module is too big and too complex. By moving the non-dependent tests closer to the code they are testing we simplify and organize. I believe that a simple and organized testing system will help encourage developers (new and old) to write more tests. It seems clear to me... --jason > Security is one example. There is secured sockets to the various > interceptors, > web container, JMS, etc. which are basic transport tests that affects > several > models. Then there is declarative security that could be in one component > layer, or involve the propagation across layers. > > Naming is another. How JNDI interacts with the components environments > is not an isolated functionality. > > Transactions are another. > > JMX is another. Sure Juha has his own little view of the JMX spec, but > given that it is the bus on which everything lives there are many > component interactions that have to be tested across modules. This is > only going to be more so as security, transactions, naming ENCs, class > loading, > etc. are brought to MBeans. > > xxxxxxxxxxxxxxxxxxxxxxxx > Scott Stark > Chief Technology Officer > JBoss Group, LLC > xxxxxxxxxxxxxxxxxxxxxxxx > > ----- Original Message ----- > From: "Jason Dillon" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Thursday, September 19, 2002 5:23 PM > Subject: RE: [JBoss-dev] Build System... any ideas > > > > Okay, no worries. What don't you get? Which tests specifically are you > > thinking of when you say then "involve several functional modules"? > > Just one for an example, so I can see where you are coming from is fine. > > > > Basically most of jboss/testsuite will remain the same, as many of those > > tests require a running JBoss instance and use many components from many > > modules to function. But there are a subset, like the proxy compiler > > tests, or the JBossMQ selector parser tests, which do not. > > > > So far most of our tests have been functional tests of a component from > > start to end. I am suggesting that we could make more tests which test > > individual parts (with out running a JBoss instance)... perhaps using > > mock objects for bits that we need to run them. This will give us more > > coverage and will allow the functional tests to simply test the > > integration & not the functionality of the individual components. > > > > By putting these independent tests in the corresponding module, we make > > the testsuite more maintainable by preventing jboss/testsuite from > > becoming insanely huge. > > > > Does that make sense or shall I explain more. Perhaps I am not wording > > things correctly, or I am taking some bit of knowledge for granted? > > > > --jason > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-development ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
