A general problem I'm seeing in this code is going through the MBeanServer to create 
these
management object MBeans instead of just creating the instance and then registering 
it. It
takes about 2-3 times as many lines of code to do this and is just unreadable. Is 
there a
reason for this? For example this:

         ObjectName lServer = getServer().createMBean(
               "org.jboss.management.j2ee.J2EEServer",
               null,
               new Object[]{
                  "Local",
                  getObjectName(),
                  "jboss.org",
                  "3.2"
               },
               new String[]{
                  String.class.getName(),
                  ObjectName.class.getName(),
                  String.class.getName(),
                  String.class.getName()
               }
         ).getObjectName();

is the same as this:

         J2EEServer j2eeServer = new J2EEServer("Local",
                  getObjectName(),
                  "jboss.org",
                  "3.2");
         ObjectName lServer = j2eeServer.getObjectName();
         getServer().registerMBean(j2eeServer, lServer);

with the latter being type checked by the compiler instead of runtime checking
being done by the MBeanServer.

xxxxxxxxxxxxxxxxxxxxxxxx
Scott Stark
Chief Technology Officer
JBoss Group, LLC
xxxxxxxxxxxxxxxxxxxxxxxx

----- Original Message ----- 
From: "Sacha Labourey" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, January 16, 2003 10:03 AM
Subject: RE: [JBoss-dev] JSR-77 refactoring has begun


> > I agree that if you take the spec and literally create a MBean
> > for every management
> > object there will be an absurd number of MBeans. So what does this super
> > MBean look like?
> 
> Is that really a problem? What if the overhead of an MBean? If that is
> really a problem because the "routing" logic of the MBeanServer will take
> too much gime, why not simply create a second MBeanServer, just for JSR-77
> purposes?
> 
> 
> 
> -------------------------------------------------------
> This SF.NET email is sponsored by: Thawte.com
> Understand how to protect your customers personal information by implementing
> SSL on your Apache Web Server. Click here to get our FREE Thawte Apache 
> Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/jboss-development
> 


-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com
Understand how to protect your customers personal information by implementing
SSL on your Apache Web Server. Click here to get our FREE Thawte Apache 
Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to