Patches item #892783, was opened at 2004-02-08 11:06
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376687&aid=892783&group_id=22866
Category: JBossServer
Group: v3.2
Status: Open
Resolution: None
Priority: 5
Submitted By: Anatoly Shein (shein1861)
Assigned to: Nobody/Anonymous (nobody)
Summary: interpreting system property from XML, fix FR #890445
Initial Comment:
This patch allows define system property in XML
configuration files, including jar meta-inf nested in sar,
depends statements and service names. See feature
request #890445. This patch dosn't fixs jgroups mcast
parametres.
The patch includes MetaData.java from
org.jboss.metadata and ServiceConfigurator.java from
org.jboss.system. See attached files.
diff -u output :
--- download/misc/jboss-3.2-
snapshot/server/src/main/org/jboss/metadata/MetaData.j
ava Thu Jan 8 02:00:45 2004
+++ MetaData.java Sun Feb 8 09:52:16 2004
@@ -185,7 +185,9 @@
result += children.item(i).getFirstChild();
}
}
- return result.trim();
+ result = result.trim();
+ return ( !isSystemProperty( result ) ) ? result
+ : resolveSystemProperty( result );
}
public static String getFirstElementContent(Element
element, String defaultStr)
throws DeploymentException
@@ -214,7 +216,9 @@
}
*/
}
- return result.trim();
+ result = result.trim();
+ return ( !isSystemProperty( result ) ) ? result
+ : resolveSystemProperty( result );
}
/**
--- download/misc/jboss-3.2-
snapshot/system/src/main/org/jboss/system/ServiceConfi
gurator.java Sat Jan 3 15:48:23 2004
+++ ServiceConfigurator.java Sun Feb 8
10:47:26 2004
@@ -605,7 +605,7 @@
private ObjectName parseObjectName(final Element
element)
throws Exception
{
- String name = element.getAttribute("name");
+ String name = resolveName( element.getAttribute
("name") );
if (name == null || name.trim().equals(""))
{
@@ -630,7 +630,17 @@
} // end of for ()
if( trim )
attributeText = attributeText.trim();
- return attributeText;
+
+ return resolveName( attributeText );
+ }
+
+ private String resolveName( String name ) {
+ if ( name != null && name.startsWith("${") &&
name.endsWith("}") )
+ {
+ name = name.substring(2).substring(0,
name.length() - 3 );
+ name = System.getProperty( name );
+ }
+ return name;
}
}
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=376687&aid=892783&group_id=22866
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
