Also we don't
catch (Exception e)
{
e.printStackTrace();
}
and even worse
catch (Exception ignored)
{
// Nothing (eating exceptions is usually bad)
}
It should be
catch (Exception e)
{
log.warn("Some message", e); // for something unexpected or
log.trace("Some message", e); // otherwise
}
Nor do we "log and throw". This just leads to logs that
are full of the same error message.
If you don't handle the exception, don't log it.
The only place that should log and throw are well defined
entry points like org.jboss.ejb.plugins.LogInterceptor
or org.jboss.deployment.MainDeployer
catch (Exception e)
{
log.error("Some message", e); // BAD - swamps the user
throw e;
}
On Fri, 2004-10-15 at 18:43, Adrian Brock wrote:
> This is a friendly reminder for those who don't know about this
> constraint.
>
> JBoss-3.2.x is a j2ee1.3 implementation and as such, it must be
> able to run on j2se 1.3. You cannot use java apis from j2se 1.4.
>
> I'm going to go through the current codebase and remove all
> usage of j2se 1.4 apis.
>
> Examples:
> 1) URLDecode.decode(String) - no workaround
>
> 2) Boolean.valueOf(boolean)
> I'm introducing a new method
> Boolean org.jboss.util.Primitives.valueOf(boolean)
> to replace this.
>
> 3) throw new RuntimeExecption(Throwable)
> use throw new org.jboss.util.NestedRuntimeException(Throwable)
>
> There is also a problem with some SSL classes from j2se 1.4
> that needs to be conditionally compiled if we are going to
> support compilation on j2se 1.3
--
xxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Director of Support
Back Office
JBoss Inc.
xxxxxxxxxxxxxxxxxxxxxxxx
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
JBoss-Development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
