A few suggestions: It might be good to take less of a factory approach. Make JDBC and BDB both subclasses of Store and make Store an MBean. The JMX name will be passed to SMTP/POP via JMX attributes/depends. This will also give us a convienent way of doing things like configuring the select statement(s) for the JDBC3 store.
It is probably preferrable for the Store to assign the GUID rather than the client. This lets us do things like use sequences with databases that support it in the future. Its not clear to me whether you're intending to always read the blobs with this BlobInputStream/etc. Part of the intent here is to keep memory footprint low for large messages. Meaning small messages may be kept in the database and fully read "disconnected", but large ones will be streamed directly from the DB to the POP/IMAP client. Reading it disconnected will defeat the purpose when that is our goal. However, buffering will need to be used of course and it should be configurable. It could be I'm missing something (there's some coupling code missing ATM so some things aren't as obvious as they will be and I've only given a cursory glance). We're going to need to switch to the new JavaMail to take full advantage of this of course. We need to test to make sure JavaMail doesn't do something lame like read the whole body in when you pass it as a stream (the JavaMail currently distributed with JB3.2.x doesn't have the input/output stream). I bet this is going to fly when we get it going. -Andy View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3861059#3861059 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3861059 ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
