[ http://jira.jboss.com/jira/browse/JBAS-1498?page=comments#action_12315626 ] Adrian Brock commented on JBAS-1498: ------------------------------------
By all means fix it. It certainly shouldn't be eating the exception and not displaying the underlying cause/problem. > RARDeployment throws incorrect IllegalArgumentException for underlying > ManagedConnectionFactory exceptions > ---------------------------------------------------------------------------------------------------------- > > Key: JBAS-1498 > URL: http://jira.jboss.com/jira/browse/JBAS-1498 > Project: JBoss Application Server > Type: Bug > Components: JCA service > Versions: JBossAS-4.0.1 SP1, JBossAS-4.0.1 Final, JBossAS-3.2.7 Final, > JBossAS-3.2.6 Final, JBossAS-4.0.1RC1, JBossAS-4.0.0 Final, JBossAS-3.2.5 > Final > Reporter: Jim Moran > Priority: Minor > > > In > org.jboss.resource.connectionmanager.RARDeployment.setManagedConnectionFactoryAttribute(String > name, Class clazz, Object value, boolean mustExist) > try > { > setter.invoke(mcf, new Object[] {value}); > log.debug("set property " + name + " to value " + value); > } > catch (Exception e) > { > String error = "Unable to invoke setter method '" + setter + "' " + > "on object '" + mcf + "'"; > if (mustExist) > throw new IllegalArgumentException(error); > else > { > log.trace(error); > return; > } > } > When ANY exception is caught from an invocation of the > ManagedConnectionFactory's setter method an IllegalArgumentException is > thrown. This can be misleading depending on the actual exception thrown from > the ManagedConnectionFactory's setter (see SalesForce case#00003103). > Either the underlying exception should be wrapped in a > org.jboss.resource.JBossResourceException and thrown or the underlying > exception should be logged inline or both. In the case of an > InvocationTargetException the target exception could be wrapped/logged/etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
