Also this code is in 3.2.x so we need to get it sorted before
3.2.8 goes out.

On Sun, 2006-01-22 at 08:48, Adrian Brock wrote:
> On Sun, 2006-01-22 at 08:30, Tom Elrod wrote:
> > So how should the be addressed when using 1.4?  I just added used of 
> > Timer for client side leases within remoting.
> > 
> 
> I think we should reinstate the old code for TimeoutFactory
> and add a shutdown method.
> 
> Avoid using java.util.Timer
> Even that purge() method has poor performance semantics.
> It scans all the registrations everytime.
> 
> > Adrian Brock wrote:
> > > 1.5 added a  java.util.Timer.purge()
> > > 
> > > I didn't realise Elias had changed TimeoutFactory to use a Timer.
> > > He said he was just changing it so it can be used as something
> > > other than a singleton:
> > > http://jira.jboss.com/jira/browse/JBAS-2205
> > > 
> > >>From the cvs commit, it looks like he did this because the
> > > old implementation didn't have a "shutdown" method:
> > > http://anoncvs.forge.jboss.com/viewrep/JBoss/jboss-common/src/main/org/jboss/util/timeout/TimeoutFactory.java
> > > See version 1.4
> > > 
> > > On Sun, 2006-01-22 at 03:18, Scott M Stark wrote:
> > > 
> > >>The issue is that the cancelation of the timer is not removing its
> > >>association from the java.util.Timer as the TimerTask.cancel just marks
> > >>the TimerTask.state as cancelled, but its not removed until the timer
> > >>actually expires. This was leading to a huge list of transaction timeout
> > >>objects and the associated object graph. Clearing the TimeoutImpl refs
> > >>in cancel restricts the transient buildup to just the TimeoutImpl. I
> > >>don't see a way to immeadiate disassociate the TimeoutImpl from the
> > >>java.util.Timer internals.
> > >>
> > >>
> > >>>-----Original Message-----
> > >>>From: [EMAIL PROTECTED] 
> > >>>[mailto:[EMAIL PROTECTED] On 
> > >>>Behalf Of Scott M Stark
> > >>>Sent: Saturday, January 21, 2006 10:12 PM
> > >>>To: jboss-development@lists.sourceforge.net; Bill Burke
> > >>>Subject: RE: [JBoss-dev] RE: ejb3-4.0-testsuite Build Failed
> > >>>
> > >>>So after profiling this the problem looks to be recent 
> > >>>changes in org.jboss.util.timeout.TimeoutFactory as the leaks 
> > >>>are related to transaction timeouts. By clearing the 
> > >>>TimeoutFactory$TimeoutImpl references the test gets past the 
> > >>>OME, but there are 73k TimeoutFactory$TimeoutImpl left after 
> > >>>the test has completed and has been undeployed. One gc root 
> > >>>is the java.util.TimerThread task queue.
> > >>>
> > >>>
> > >>>>-----Original Message-----
> > >>>>From: [EMAIL PROTECTED]
> > >>>>[mailto:[EMAIL PROTECTED] On Behalf Of 
> > >>>>Scott M Stark
> > >>>>Sent: Saturday, January 21, 2006 2:17 PM
> > >>>>To: Bill Burke
> > >>>>Cc: jboss-development@lists.sourceforge.net
> > >>>>Subject: [JBoss-dev] RE: ejb3-4.0-testsuite Build Failed
> > >>>>
> > >>>>This is just the 
> > >>>
> > >>>org.jboss.ejb3.test.microbench.unit.BenchUnitTestCase
> > >>>
> > >>>>requiring too much memory. Memory usage during this test 
> > >>>
> > >>>goes from 40m 
> > >>>
> > >>>>to 130m even using the default config so the memory usage of this 
> > >>>>needs to be looked at.
> > >>>
> > >>>
> > >>>-------------------------------------------------------
> > >>>This SF.net email is sponsored by: Splunk Inc. Do you grep 
> > >>>through log files for problems?  Stop!  Download the new AJAX 
> > >>>search engine that makes searching your log files as easy as 
> > >>>surfing the  web.  DOWNLOAD SPLUNK!
> > >>>http://sel.as-us.falkag.net/sel?cmd=k&kid3432&bid#0486&dat1642
> > >>>_______________________________________________
> > >>>JBoss-Development mailing list
> > >>>JBoss-Development@lists.sourceforge.net
> > >>>https://lists.sourceforge.net/lists/listinfo/jboss-development
> > >>>
> > >>
> > >>
> > >>-------------------------------------------------------
> > >>This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> > >>files
> > >>for problems?  Stop!  Download the new AJAX search engine that makes
> > >>searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> > >>http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642
> > >>_______________________________________________
> > >>JBoss-Development mailing list
> > >>JBoss-Development@lists.sourceforge.net
> > >>https://lists.sourceforge.net/lists/listinfo/jboss-development
> > 
> > 
> > 
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> > for problems?  Stop!  Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> > _______________________________________________
> > JBoss-Development mailing list
> > JBoss-Development@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/jboss-development
-- 
xxxxxxxxxxxxxxxxxxxxxxxx 
Adrian Brock
Chief Scientist
JBoss Inc.
xxxxxxxxxxxxxxxxxxxxxxxx 



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to