Hi, Len Trigg <[email protected]> writes:
> I had a quick scan of them now, and will try and look at some of them > in more detail on Monday - I have some initial comments, and would > like to see what others think. Thank you! >> * Patches for the installation procedure: >> >> 1. >> https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/installation-layout.patch > > Wouldn't this mean that all those removed properties need to be in the > external build.properties file? That's right. The `configurePhase' of the package at https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/default.nix does exactly this. > In the antfiles I write I usually include external properties files at > the start of the build.xml (rather than inside the init target as we > currently have in jdee), so that properties defined in the xml itself > are treated as defaults that can always be overridden. Perhaps we > should do that instead? Hmm, possibly. I agree there should be default values when `build.properties' doesn't specify anything. >> 2. >> https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/cedet-paths.patch > > I would like to test that this also works when pointing at a > non-system-installed cedet The installed CEDET is flat (all elisp files in a single directory), whereas the CEDET sourec has sub-directories for `common', `eieio', etc. > (as I guess many people who build jdee themselves run like that). I would expect non-Windows users to always use an installed CEDET. What do you think? >> 3. >> https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/elib-avltree.patch > > This looks good - it'd be great to no longer need external avltree as a > dependency. IIRC, the `avl-tree' elisp module is only available in the forthcoming Emacs 23, which could be an issue. Thanks, Ludo'. ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ jdee-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jdee-users
