I found another crash in mod_groups in 1.4.2.  This was due to the code trying to free 
an xmlnode which had never been initialized.  It happens on the browse-set callback 
when the incoming packet does not have a proper <user> tag formed.  Here is a patch 
which fixes it.  This patch should be applied on top of the other patch I submitted 
here a few weeks ago. 

  Nathan


--- mod_groups.c.withCrash      Thu May  9 17:22:33 2002
+++ mod_groups.c        Mon Jun 10 09:18:16 2002
@@ -594,7 +594,6 @@
     if (uid == NULL || un == NULL)
     {
         js_bounce(m->si,jp->x,TERROR_NOTACCEPTABLE);
-        xmlnode_free(info);
         return;
     }
 

Reply via email to