On 02/07/2012 03:18 PM, Valerie (Yu-Ching) Peng wrote: > This was discussed in JDK8 and then later backported to 7u. > The majority of the code is under the closed tree, so the changes are > reviewed internally.
Ah, I was not aware of that. From what I have seen of other patches, the external changes are still reviewed externally: http://mail.openjdk.java.net/pipermail/hotspot-dev/2011-December/004805.html Besides, I am concerned that Rule 4 of the JDK 7 Updates: Ground Rules [1] was violated and that this changeset was not approved publicly on the jdk7u-dev mailing list (nor was a url to the place where the patch was reviewed provided). Perhaps the rules need to be adjusted to clarify how cases like this should be handled? Cheers, Omair [1] http://openjdk.java.net/projects/jdk7u/groundrules.html
