In general, I don't see a problem with backporting a P4 or P5 fix into 7u8 as such, as in particular for new Authors beginning to contribute to this Project, backporting 'easy' fixes can be a good way to get started, and build up their reputation in the community.
But before one of the maintainers looks at approving it, I would like to see questions raised in Pavel's review resolved. cheers, dalibor topic On 7/18/12 11:30 AM, Pavel Porvatov wrote: > Hi Charles, >> Hi all, >> >> Requesting for approval to push the changes to add mnemonic for JFileChooser >> metal and motif Laf >> >> Changeset for jdk8 @ http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477 >> Changeset for jdk7u-dev @ >> http://cr.openjdk.java.net/~littlee/jdk7u/197/webrev.00/ >> <http://cr.openjdk.java.net/%7Elittlee/jdk7u/197/webrev.00/> >> >> Please notice that, changeset for jdk7u-dev is part of the changeset for >> jdk8, because "CR 7093156 - NLS: Please change the mnemonic assignment >> system to avoid translation issue" has already been committed in jdk7u-dev >> (jdk7u6)[1]. > I'm observing that http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477 > has motif*.properties changes, but [1] doesn't have that changes. It seems > your fix is not completed, because now in jdk8 file motif.properties (and > others) contains > FileChooser.pathLabel.textAndMnemonic=Enter &path or folder name: > > but jdk7u-dev contains > FileChooser.pathLabel.textAndMnemonic=Enter path or folder name: > > Could you please clarify that? Which tests have you passed with the fix? > > I'm also not sure that we want backport P4 bugs into 7u8. Do you have any > justification for that? > > Regards, Pavel >> >> Reviewed by: >> Alexander Potochkin >> >> [1]: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/003003.html >> > -- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
