You can mark me as a reviewer if you wish, but you'll still need someone
else with jdk7u reviewer status!
regards,
Sean.
On 20/09/2012 19:26, Stuart Marks wrote:
Thanks. Can I get a code review from someone as well? Or does this
constitute both code review and push approval? :-)
s'marks
On 9/20/12 3:11 AM, Seán Coffey wrote:
Approved for jdk7u-dev.
regards,
Sean.
On 20/09/2012 06:49, Stuart Marks wrote:
This is a request for review and approval to push a change to add
several
tests to the problem list in 7u. These tests are already on the
problem list
in JDK8. They were added by Michael McMahon and Alan Bateman (cc'd).
The tests in question are among the set of tests listed in this bug
report:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7162111
which fail intermittently and unpredictably on the Mac because of
issues
running AWT in our automated test environment. Michael previously
had added a
bunch of tests in this category to the problem list:
http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002699.html
http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-April/002712.html
but these tests were left out of that batch for some reason.
The bug report that covers this change is here:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199637
(It's not visible as of the time of the sending of this message, but
basically it's a placeholder bug to cover this changeset.)
Patch appended below.
Thanks,
s'marks
# HG changeset patch
# User smarks
# Date 1348119080 25200
# Node ID b09591f57ef978686f91112c63ae56cb26ef43ee
# Parent cd32baf1524847463bab29b83b9fe33740a37313
7199637: TEST_BUG: add serialization tests to jdk7u problem list for
macosx
Reviewed-by: XXX
diff -r cd32baf15248 -r b09591f57ef9 test/ProblemList.txt
--- a/test/ProblemList.txt Mon Sep 17 14:26:26 2012 -0700
+++ b/test/ProblemList.txt Wed Sep 19 22:31:20 2012 -0700
@@ -435,6 +435,11 @@
# 6962637
java/io/File/MaxPathLength.java windows-all
+# 7162111 - these tests need to be updated to run headless
+java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all
+java/io/Serializable/serialver/classpath/run.sh macosx-all
+java/io/Serializable/serialver/nested/run.sh macosx-all
+
############################################################################
# jdk_nio
