Sean,

It was approved by Edvard. It was a backport, so I used the backport ID, see "Request for approval for 8005086: [findbug] some fields should be package protected".

I'll use the main ID instead in the future.

Thanks,
Joe

On 12/18/2012 2:37 AM, Seán Coffey wrote:
Joe,

I didn't see a push approval request for this changeset. To be consistent and in line with the OpenJDK 7u process, can I ask you to file a retrospective approval request ?

http://openjdk.java.net/projects/jdk7u/approval-template.html

regards,
Sean.

On 18/12/2012 06:52, [email protected] wrote:
Changeset: f7a0897308d5
Author:    joehw
Date:      2012-12-17 22:54 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/f7a0897308d5

8003260: [findbug] some fields should be package protected
Summary: change public or protected mutable static fields to private or package private.
Reviewed-by: lancea

! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java
! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java


Reply via email to