Approved. /Edvard
On Jan 22, 2013, at 9:51 PM, Joe Darcy <[email protected]> wrote: > Hello, > > Please review the patch below for inclusion into 7u14. Some background to > explain what is going on. The issue 7131459 [1] has already been fixed in > JDK 8 to address some long-standing numerical irregularities in certain > double -> string conversions: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc1f16f5566 > > However, the patch below does not represent a straight backport of this work. > In the 7 update train, this fix is only going to be used when 7050528 [2] is > used and 7050528 is only used in closed code. 7050528 is a performance > optimization with the improved numerical behavior and 7131459 provides > consistency in the non-optimized cases. > > For the 7 update train, to make this happen some changes are needed in closed > code (not sent to this list), but one small build changes is needed to an > open makefile which controls the building of a jar file only used in the > closed product; patch below: > > diff --git a/make/altclasses/Makefile b/make/altclasses/Makefile > --- a/make/altclasses/Makefile > +++ b/make/altclasses/Makefile > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. > +# Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights > reserved. > # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > # > # This code is free software; you can redistribute it and/or modify it > @@ -42,6 +42,7 @@ ALTRT_JAR_FILE = $(LIBDIR)/alt-rt.jar > ALTRT_JAR_FILE = $(LIBDIR)/alt-rt.jar > ALTRT_JAR_SOURCE_FILE = $(TEMPDIR)/alt-rt.jarsrclist > ALTRT_JAR_SOURCES = $(wildcard $(ALTCLASSES_SRCDIR)/java/*/*.java) > +ALTRT_JAR_SOURCES += $(wildcard $(ALTCLASSES_SRCDIR)/sun/misc/*.java) > > Thanks, > > -Joe > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131459 > > [2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7050528
