Now pushed to jdk7u-dev/jdk [1]. Regards, Neil
[1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d91e77f0de85 On Fri, 2013-05-17 at 17:21 +0800, Frank Ding wrote: > Good catch. Thanks. > > Best regards, > Frank > On 5/10/2013 8:54 PM, Seán Coffey wrote: > > Thanks Frank. One last request before you push if possible. Given that > > 7189299 is no longer a valid bug reference (I can't find it in bug > > system) - can you rename the testcase directory also. It'll help > > future code maintenance. > > > > change 7189299/ to 8008289/ > > > > No need to re-submit a webrev for that! > > > > regards, > > Sean. > > > > On 10/05/13 04:48, Frank Ding wrote: > >> Hi Sean, > >> I have updated review patch according to your comment @ > >> http://cr.openjdk.java.net/~dingxmin/jdk7u/7189299/webrev.01 > >> > >> Best regards, > >> Frank > >> > >> On 5/10/2013 2:43 AM, Seán Coffey wrote: > >>> Frank, > >>> > >>> looks like bug 7189299 was migrated over to the JDK project and > >>> became bug ID 8008289 as per jdk8 changeset. > >>> > >>> http://bugs.sun.com/view_bug.do?bug_id=8008289 > >>> > >>> Can you update the bug reference in the src code before pushing ? > >>> "// when a new UI component is replaced. See bug 7189299." > >>> > >>> Likewise, update the @bug tag in the testcase to 8008289 > >>> > >>> Approved for 7u-dev. > >>> > >>> regards, > >>> Sean. > >>> > >>> On 09/05/2013 07:55, Frank Ding wrote: > >>>> Hi all, > >>>> > >>>> I'd like to request for approval to push the following change > >>>> into 7u. The patch in 7u is exactly identical to the one in 8. > >>>> > >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7189299 > >>>> (the link is not available) > >>>> > >>>> Changeset in jdk8 > >>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4bf242def958 > >>>> Reviewed by alexsch, malenkov > >>>> > >>>> Webrev for 7u > >>>> http://cr.openjdk.java.net/~dingxmin/jdk7u/7189299/webrev.00/ > >>>> > >>>> Starting email discussion thread > >>>> http://mail.openjdk.java.net/pipermail/swing-dev/2012-August/002182.html > >>>> > >>>> > >>>> Best regards, > >>>> Frank > >>>> > >>> > >> > > > -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
