Daniel,
since the changeset differs from that of the jdk8 one, can you get a
review carried out? I'm cc'ing Alan and Joe here.
Consider this approved pending code review.
regards,
Sean.
On 29/05/13 18:33, Daniel Fuchs wrote:
Hi,
This is a request for approval to backport the changes for:
<https://jbs.oracle.com/bugs/browse/JDK-8008738>
The review for the original fix happened for jdk8 on the
core-libs-dev list, in these two thread:
<http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/016037.html>
<http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016602.html>
The changeset for jdk7u-dev only slightly differs from that
for jdk 8, on these two counts:
1. JAXP needs to be compiled with the bootstrap JDK - which
means that JAXP in jdk 7 cannot depend on new jdk 7 APIs.
In Encodings.java I had to replace a try-with-resource by
a try-finally.
2. The jdk/test/Makefile needed to be updated in order to add
javax/xml/jaxp to the jdk_other target.
Here is the webrev for the changeset pushed in jdk8:
http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev.03/
Here is the webrev for jdk7u-dev:
http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev-jdk7u-dev.00/
Best regards,
-- daniel
