Once you have the necessary code reviews obtained, consider this
approved for jdk7u-dev.
regards,
Sean.
On 06/06/13 16:32, Konstantin Shefov wrote:
On 06-Jun-13 19:17, Alan Bateman wrote:
On 06/06/2013 16:02, Konstantin Shefov wrote:
There are a lot of test pairs (.java + .html) in JDK repo where both
files contain jtreg tags, although only one file contains @test tag.
I think it is not necessary to remove other tags, because they show
that the given file is a part of the given test for @bug and its
author, etc.
Have you considered just using comments rather than duplicating the
jtreg tags? Otherwise I think it is a bit error prone as it looks
like a test is missing @test (which might be how the duplicates ended
up being added here).
I think it may be so (about how the duplicates appeared), but there
are still many such pair-tests in WS (both with JTREG tags and only
one with @test tag). I will add comments that those files are a only
parts of tests and no @test tag is needed there and remove unnecessary
jtreg tags.
-Alan.
