If you want to see whitespace changes, there is webrev's -b option.
Brad
On 10/3/2013 2:29 AM, Chris Hegarty wrote:
On 10/03/2013 10:07 AM, Miroslav Kos wrote:
Hi,
see inline.
On 10/2/13 5:55 PM, Seán Coffey wrote:
Miran, Jeff,
Looks like webrev doesn't show up the indentation changes. You'll see
them in the patch link from webrev. This seems to be a review request
and an approval request. 7u40 has shipped however. This can go into
7u-dev[7u60]. Consider it approved for jdk7u-dev but that's
conditional on getting an OpenJDK reviewer to approve first.
I took a look at the changes in the webrev, and they look benign to me.
If they build and test, I am happy to be considered a reviewer for this
change.
-Chris.
What to do to get it? Any action from me necessary?
Please add the '8-na' label to bug report.
label added
regards,
Sean.
On 02/10/13 15:32, Jeff Dinkins wrote:
Hi Miroslaw:
At least one of these comes up blank:
http://cr.openjdk.java.net/%7Emkos/8025713/webrev-jaxws.00/src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilder.java.sdiff.html
Is that ok?
And this one seems to be changing the copyright from 2013 to 2012 -
is that right?
Yes, I believe it should be ok - the change in upstream project was done
sooner, then the actual jdk release has been done, so the copyright
years are different; 2012 should be ok.
Regards
Miran
http://cr.openjdk.java.net/%7Emkos/8025713/webrev-jaxws.00/src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MemoryData.java.sdiff.html
-jeff
On Oct 2, 2013, at 5:56 AM, Miroslav Kos <[email protected]>
wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8025713
Description: There are some changes in upstream projects and one of
them are differences not changing semantics, but always appearing in
diff after preparing source bundle for jdk. Fixing this will help
for next integrations and will avoid risk to overlook some important
change in code.
Review for this should be fast and easy, no actual code change.
Changeset to be reviewed:
http://cr.openjdk.java.net/~mkos/8025713/webrev-jaxws.00/
<http://cr.openjdk.java.net/%7Emkos/8025713/webrev-jaxws.00/>
JDK8 changeset: not applicable, different code basis
