[ http://issues.apache.org/jira/browse/JDO-215?page=comments#action_12358440 ]
Craig Russell commented on JDO-215: ----------------------------------- As discussed on the JDO expert group, the primary-key annotation is only needed for cases where there is an embedded Map key or Set element that doesn't have a unique key field already known. That is, for embedded SimpleClass with datastore identity used as Map keys or Set elements. The other cases have a known unique field that can be used to make the rows unique. For embedded SimpleClass with appication identity, it's the id field. For non-embedded SimpleClass, it's the foreign key reference. > Remove <order> from mapping for HashSetCollections and SetCollections. > ---------------------------------------------------------------------- > > Key: JDO-215 > URL: http://issues.apache.org/jira/browse/JDO-215 > Project: JDO > Type: Bug > Components: tck20 > Reporter: Craig Russell > Assignee: Michelle Caisse > Attachments: JDO-215.patch > > The mapping for HashSetCollections and SetCollections incorrectly have > <order> columns. > There should not be an ordering specified for the join table since duplicates > are not allowed. The mapping for application identity should not need a > primary key, since the JDO implementation should be able to figure out that > the primary key is part of the Map.key, but the datastore identity mapping > does need a primary key (and again, I'd use the id field of SimpleClass as > the join table key column. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
