[ http://issues.apache.org/jira/browse/JDO-264?page=comments#action_12361070 ]
Michelle Caisse commented on JDO-264: ------------------------------------- CLR: "I think that if we define the enhancer execution classpath (where the iut.enhancer.main and its dependencies can be found) and enhancer source classpath (where the un-enhanced classes and .jdo metadata files are found) plus enhancer properties (arbitrary command line arguments for the execution of the enhancer) we are covered. Then there should be minimum requirement to change the maven.xml but instead simply update the provided sample iut.properties file (with all the properties commented)." 0.a. I don't think the enhancer source classpath is needed in the iut.properties file because it is determined by the build itself and therefore known to maven.xml. 0.b. Do you agree that there is no benefit to setting the jdori enhancer classpaths in project.properties over setting them in maven.xml? 1. You are correct that the jpox enhancer will run out of the box with this patch. I did this mainly for convenience in debugging, but I can change it now. 2. Yes, everything works. Those lines that I commented out in project.properties were never referenced in maven.xml Commenting them out only serves to prove that. If the answer to 0.b. is "yes", I will delete them. 3. I agree with you and it bothers me too. I will happily make this change. 4. Good idea. I will make the change. > Fix issues in maven.xml preventing iut goals from running properly > ------------------------------------------------------------------ > > Key: JDO-264 > URL: http://issues.apache.org/jira/browse/JDO-264 > Project: JDO > Type: Bug > Components: tck20 > Reporter: Michelle Caisse > Assignee: Michelle Caisse > Attachments: enhanceClasspath.patch > > maven.xml has not been properly tested on an implementation under test (iut). > Test and fix any problems encountered. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
