Anyone care to comment so that I can commit the changes? --matthew
>-----Original Message----- >From: Matthew T. Adams (JIRA) [mailto:[EMAIL PROTECTED] >Sent: Monday, January 23, 2006 10:58 AM >To: [email protected] >Subject: [jira] Updated: (JDO-282) Add convenience methods to >get persistent instance and detached instance from >InstanceLifecycleEvent > > > [ http://issues.apache.org/jira/browse/JDO-282?page=all ] > >Matthew T. Adams updated JDO-282: >--------------------------------- > > Attachment: InstanceLifecycleEvent.java.2.patch > >OK, attached is the refactored patch. Please review and >comment. I opted not to use the boolean at all, as >isPreCallback and other variants of the name either weren't >correct or just weren't descriptive enough. > >> Add convenience methods to get persistent instance and >detached instance from InstanceLifecycleEvent >> >--------------------------------------------------------------- >------------------------------------- >> >> Key: JDO-282 >> URL: http://issues.apache.org/jira/browse/JDO-282 >> Project: JDO >> Type: Improvement >> Components: api20 >> Reporter: Matthew T. Adams >> Assignee: Matthew T. Adams >> Attachments: InstanceLifecycleEvent.java.2.patch, >InstanceLifecycleEvent.patch >> >> The source and target object differ as to whether they are >the persistent or detached instance in class >InstanceLifecycleEvent depending upon whether the event object >is given in the preDetach, postDetach, preAttach, or >postAttach callbacks. I propose adding two convenience >methods that makes it obvious from the API which object the >user is getting. > >-- >This message is automatically generated by JIRA. >- >If you think it was sent incorrectly contact one of the administrators: > http://issues.apache.org/jira/secure/Administrators.jspa >- >For more information on JIRA, see: > http://www.atlassian.com/software/jira > >
