[ 
http://issues.apache.org/jira/browse/JDO-374?page=comments#action_12376036 ] 

Michael Bouschen commented on JDO-374:
--------------------------------------

I have two comments/questions about the patch:
- Please update the description text of the tck20.dist goal. It can use the 
same text as the help output for tck20.dist.
- I'm wondering about the call <attainGoal name="tck20.default"> in the middle 
of the tck20.dist body? Is this intentional? If yes, I propose to use the 
prereqs attribute instead:
   <goal name="tck20.dist" prereqs="tck20.default">
          description="Creates distributions of tck20 and dependent JDO2 
projects">
        <j:set var="maven.multiproject.includes">${tck20.projects}</j:set>
        <j:set var="goal">dist</j:set>
        <attainGoal name="multiproject:goal"/>
    </goal>



> Add a maven target to create distribution artifacts for all subprojects of 
> tck20
> --------------------------------------------------------------------------------
>
>          Key: JDO-374
>          URL: http://issues.apache.org/jira/browse/JDO-374
>      Project: JDO
>         Type: Improvement

>   Components: tck20, api20, core20, enhancer20
>     Versions: JDO 2 rc1
>     Reporter: Craig Russell
>     Priority: Minor
>      Fix For: JDO 2 final
>  Attachments: JDO-374.patch
>
> There are several maven tck20 build targets. I propose to add a target that 
> builds the distribution targets for all subprojects of tck20.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to