Hi Craig,

> I think we should remove Person.class and Employee.class from the list
> of teardown classes in CompletenessTest. Having them there doesn't serve
> any purpose since no instances of these classes are created, and they
> can create issues when trying to remove instances using a different
> strategy.
> 
> For example, look at http://issues.apache.org/jira/browse/JDO-285 for
> other issues related to this.
> 
> What do you think?

I agree. The changes are straightforward, I attached a patch to JDO-375.

Regards Michael

> 
> Craig
> 
> On Apr 30, 2006, at 8:11 AM, Michael Bouschen (JIRA) wrote:
> 
>>      [ http://issues.apache.org/jira/browse/JDO-375?page=all ]
>>
>> Michael Bouschen reassigned JDO-375:
>> ------------------------------------
>>
>>     Assign To: Erik Bengtson  (was: Michael Bouschen)
>>
>> I checked in the patch fixing getting the tearDown classes from the
>> correct reader plus fixing list of tearDown classes in
>> CompanyFactoryPMClass into the trunk and the 2.0 branch (see revision
>> 398354).
>>
>> I think the remaining issue from preventing a correct cleanup after
>> the test is, that the extent of a persistent interface does not
>> include any instances. I'm assigning this issue back to Erik.
>>
>>> Company model tables are not fully cleaned up
>>> ---------------------------------------------
>>>
>>>          Key: JDO-375
>>>          URL: http://issues.apache.org/jira/browse/JDO-375
>>>      Project: JDO
>>>         Type: Bug
>>
>>>   Components: tck20
>>>     Versions: JDO 2 rc1
>>>     Reporter: Erik Bengtson
>>>     Assignee: Erik Bengtson
>>>      Fix For: JDO 2 final
>>>  Attachments: JDO-375.patch
>>>
>>> Tables from company model does not appear to be clean after run.
>>> I can't say if this is a JPOX or TCK issue, because I did not dig
>>> into the issue.

[...]

-- 
Michael Bouschen                [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        http://www.tech.spree.de/
Tel.:++49/30/235 520-33         Buelowstr. 66                   
Fax.:++49/30/2175 2012          D-10783 Berlin                  

Reply via email to