[ http://issues.apache.org/jira/browse/JDO-386?page=comments#action_12416622 ]
Craig Russell commented on JDO-386: ----------------------------------- Looks good! Just one comment. You might want to modify this line of maven.xml to include LICENSE.txt and NOTICE.txt. <echo>Copying top-level README.txt to ${maven.dist.bin.archive.dir}</echo> > All distributions (source and binary) need to include NOTICE file > ----------------------------------------------------------------- > > Key: JDO-386 > URL: http://issues.apache.org/jira/browse/JDO-386 > Project: JDO > Type: Bug > Components: api20, tck20 > Versions: JDO 2 final > Reporter: Craig Russell > Assignee: Michael Bouschen > Fix For: JDO 2 maintenance release 1 > Attachments: JDO-386.patch > > The distributions need to include a NOTICE file in the same directory as the > LICENSE file. Both the source and binary distributions need this file. > For details, see http://www.apache.org/dev/apply-license.html#new summarized > as follows: > "A NOTICE file should be included in the same directory as the LICENSE file. > The NOTICE should include only those attribution notices that are required by > any part of the entire distribution. For Apache projects and those > redistributing ASF software, the NOTICE file must contain the sentence: > This product includes software developed by > The Apache Software Foundation (http://www.apache.org/). > The license is applied to each source file (code and documentation, but > excluding the LICENSE and NOTICE files) by including a short copyright notice > at the top, as demonstrated by the boilerplate notice provided in the > appendix." > I've filed this under tck20 and api20 but it applies to all Apache > distributions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira