[ http://issues.apache.org/jira/browse/JDO-445?page=comments#action_12460194 ] Guido Anzuoni commented on JDO-445: -----------------------------------
Is it absolutely (technically) impossible to implement this functionality with JTA 1.0.x ? I understand that there are some ordering issues, but if we assume that in a global txn context features like non-transactional reads might not have sense, it is sufficient that the real PM attached to a global transaction registers itself as a Synchronization and afterCompletion notify the PMProxy of the event wich physically closes the real PM, removing it from the map that bind jta transaction to real PM. If I can express an opinion, I don't like the name getPersistenceManagerProxy for the method. It is too generic, why not getJtaPersistenceManager() or getTransactionalPersistenceManager() that clearly states the role of the object returned. Guido P.S. About TransactionManager lookup, may I suggest the solution used in the patch attached to http://www.jpox.org/servlet/jira/browse/CORE-2734 ? > Add convenience method that returns a PersistenceManager proxy > -------------------------------------------------------------- > > Key: JDO-445 > URL: http://issues.apache.org/jira/browse/JDO-445 > Project: JDO > Issue Type: New Feature > Components: api2, api2-legacy > Reporter: Michelle Caisse > Assigned To: Craig Russell > Fix For: JDO 2 maintenance release 1 > > Attachments: PMProxy-patch.txt, smime.p7s > > > In Chapter 8, add a convenience method that returns a PersistenceManager > proxy that can be used in web and ejb containers to dynamically bind to the > transaction-associated PersistenceManager. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira