[
https://issues.apache.org/jira/browse/JDO-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497512
]
Michelle Caisse commented on JDO-433:
-------------------------------------
If we don't closePMF, the call to getUnconfiguredPMF() returns the standard PMF
that is created by the setUp() method in the parent class before its call to
localSetUp(). It seems to me that getUnconfiguredPMF() should either throw an
exception or close the existing pmf itself if pmf is not null, rather than
returning something which the caller may not want.
> setUp() is not declared final in org.apache.jdo.tck.JDO_Test
> ------------------------------------------------------------
>
> Key: JDO-433
> URL: https://issues.apache.org/jira/browse/JDO-433
> Project: JDO
> Issue Type: Bug
> Components: tck2
> Affects Versions: JDO 2 final
> Reporter: Michelle Caisse
> Assigned To: Michelle Caisse
> Priority: Minor
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDO-433.patch
>
>
> Tests are to override localSetUp() for test specific set up. The setUp()
> method in JDO_Test is not meant to be overriden. However, it is not
> currently declared to be final. It should be declared final and the set up
> code in the tests that do override setUp() (listed below) should be in
> localSetUp().
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManager.java:54:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager cannot
> override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerFactoryByPropertiesInstance.java:60:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerFactoryByPropertiesInstance
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerForUser.java:63:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionPassword.java:54:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword cannot
> override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionURL.java:58:
> setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionUserName.java:57:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName cannot
> override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetIgnoreCache.java:53:
> setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetMultithreaded.java:57:
> setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalRead.java:54:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalWrite.java:54:
> setUp() in
> org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetOptimistic.java:53:
> setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetRetainValues.java:55:
> setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues
> cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is
> final
> protected void setUp() throws Exception {
> ^
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
