Re: Annotations for embedded Key, Value, and Element

[Craig L Russell]

Hi Andy,

On Jul 18, 2007, at 10:09 PM, Andy Jefferson wrote:

Hi Craig,

The only thing needed is the Embedded[] embedded() default {} element of @Key, @Value, and @Element, replacing the String embedded() that I

think has no use here.

@Element "embedded" (String) has the same use as
<collection embedded-element="...">

Yes, this is part of the separation of jdo from orm metadata. It
might make sense to preserve the name of the attributes and put the
corresponding annotation elements embeddedElement, embeddedKey, and
embeddedValue  into @Field and @Property and then use embedded() for
mapping.

namings of the global flag, and the mapping details

1. "embedded", "embeddedMapping"
2. "embeddedElement", "embedded"

I disagree on that placement of the other flags, back on to @Field/ @Property. They relate specifically to the element, key, value so keep them on the associated annotation would be my vote. So then it really comes down to

Have you looked at how to do mapping of embedded element, key, and
value with the current annotations? I might have missed something
obvious...

Looks fine to me. Should cater for all cases I have immediately to mind

    @Join(column="OWNER_FK")
    @Key(column="INTEGER")
    @Value(
        [EMAIL PROTECTED](
            fields={
                @Field(name="point1.x", column="POINT1_X"),
                @Field(name="point1.y", column="POINT2_Y"),
                @Field(name="point2.x", column="POINT2_X"),
                @Field(name="point2.y", column="POINT2_Y")
    }))
    Map<Integer, Line> integerLines;

Craig

I couldn't see how to specify embedded mappings at all without the proposed new annotations. Can you give an example similar to this one using the checked-in version? @Field(table="INTEGER_LINES", embeddedKey="true", embeddedValue="true")

--
Andy  (Java Persistent Objects - http://www.jpox.org)

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature