[ 
https://issues.apache.org/jira/browse/JDO-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569144#action_12569144
 ] 

Andy Jefferson commented on JDO-576:
------------------------------------

Tests for jdoconfig dont pass with datastore identity, only app identity
Tests for persistence.xml and JDOHelper assume that the EMF will also implement 
PMF, and JPOX doesn't implement its EMF that way - they are separate classes. 
This is an implementation level detail IMHO - as the method 
JDOHelper.getPersistenceManagerFactory it is user error if the EMF doesnt also 
implement PMF.

When calling JDOHelper(persistence-unit-name), JDOHelper could do as if the 
user had instead passed in a Properties with a single property 
"javax.jdo.option.PersistenceUnitName" set to the puName. In this case JPOX 
would return a PMF for that persistence-unit. This currently isn't part of 
JDOHelpers logic AFAIK

> Create new tests for getting a pmf using jdoconfig.xml
> ------------------------------------------------------
>
>                 Key: JDO-576
>                 URL: https://issues.apache.org/jira/browse/JDO-576
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>            Reporter: Michelle Caisse
>            Assignee: Michelle Caisse
>             Fix For: JDO 2 maintenance release 1
>
>
> New tests are needed to test getting a persistence manager factory with 
> JDOHelper.getPersistenceManagerFactory() and 
> JDOHelper.getPersistenceManagerFactory(String name);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to