[ 
https://issues.apache.org/jira/browse/JDO-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647900#action_12647900
 ] 

Ilan Kirsh commented on JDO-591:
--------------------------------

Some ideas:

(1)
void enhanceClasses(String... classNames) 
  (String... instead of String[])
And also support import style wildcard, e.g.  "my.pc.*" for all the classes in 
package my.pc.

(2)
void enhanceFiles(String... fileNames) -
- one common method for all file types (class / directory / JDO / JAR)
- support wildcards
- Directory will represent all the class / JDO / JAR in that directory and 
subdirectories.

(3)
setClassLoader(...) instead of additional parameter (as setOutputDirectory). 
Also can have chaining methods: addPersistenceUnit(...) + addClasses(...) + 
addFiles(...) + enhance() method with no args.

> Enhancer Invocation API
> -----------------------
>
>                 Key: JDO-591
>                 URL: https://issues.apache.org/jira/browse/JDO-591
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>            Reporter: Andy Jefferson
>            Assignee: Andy Jefferson
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdoenhancer.patch
>
>
> Having a standard interface to invoke the enhancer makes a lot of sense so we 
> can have interchangeability of enhancers (for implementations that support 
> BinaryCompatibility). 
> A start point (for discussions) could be
> java -cp classpath  {enhancer-class} [options] [jdo-files] [class-files]
>     where options can be
>         -persistenceUnit persistence-unit-name : Name of a "persistence-unit" 
> to enhance the classes for
>         -d target-dir-name : Write the enhanced classes to the specified 
> directory
>         -checkonly : Just check the classes for enhancement status
>         -v : verbose output
> This then allows enhancement of the specified classes, or the classes defined 
> by the specified JDO files, or the classes defined by the specified 
> persistence-unit.
> What other control would people like to see ? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to