Hi Craig,
I tried the patch on Windows and it works, good job!
Regards Michael
With regard to the enhancer handing on Windows, I just talked to Ludo
who says that you need a thread reading each of the error and output
streams. There's no Java requirement that the error and output streams
are implemented as buffered streams, so you need to read them to avoid
hanging.
I'll have a patch ready shortly.
Craig
On Aug 21, 2009, at 9:56 AM, Craig L Russell wrote:
Attendees: Michelle Caisse, Michael Bouschen, Craig Russell
Agenda:
1. Add annotations for instance callbacks
https://issues.apache.org/jira/browse/JDO-638
There is a new patch that includes the missing metadata for the
annotations.
An argument can be made that for separation of concerns, multiple
methods with the same annotation are not only acceptable but
encouraged. So in this scenario, the only check would be that the
method be niladic and return void. The order of execution of
callbacks/annotated methods is not defined.
So with this approach, mixing annotations and callbacks isn't an
error condition.
Any other ideas?
I'd also defer checking this in for JDO 2.3 until test cases have
been written.
2. tck2 does not compile with JDK 1.5
https://issues.apache.org/jira/browse/JDO-635
Since JDK 1.5 will become EOL soon, we should not spend too much
energy on this. Propose to document the issue (need to comment out
the properties line that references the 1.6 pre-processor) in a few
places.
3. Other issues
https://issues.apache.org/jira/browse/JDO-621 The enhancer main
program is complete and needs to be reviewed. Michael has tested the
patch on Windows and the subprocess seems to hang. Suggest reading
the standard output and standard error from the subprocess and look
for clues.
Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:craig.russ...@sun.com
P.S. A good JDO? O, Gasp!
Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:craig.russ...@sun.com
P.S. A good JDO? O, Gasp!
--
*Michael Bouschen*
*Prokurist*
akquinet t...@spree GmbH
Bülowstr. 66, D-10783 Berlin
Fon: +49 30 235 520-33
Fax: +49 30 217 520-12
Email: michael.bousc...@akquinet.de
Url: www.akquinet.de <http://www.akquinet.de>
akquinet t...@spree GmbH, Berlin
Geschäftsführung: Martin Weber, Prof. Dr. Christian Roth
Amtsgericht Berlin-Charlottenburg HRB 86780 B
USt.-Id. Nr.: DE 225 964 680
