[
https://issues.apache.org/jira/browse/JDO-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760008#action_12760008
]
Michelle Caisse commented on JDO-639:
-------------------------------------
The difference between the calls to the DataNucleus enhancer when specifying
classes versus directories on the command line is that when specifying classes
javax.jdo.Enhancer supplies the full path whereas when the directory is
specified, javax.jdo.Enhancer supplies only the class name:
Original code listing each class:
[java] Enhancer adding class file
org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppAddress.class.
...
Modified code listing directories:
[java] Enhancer adding jdo file package.jdo.
[java] Enhancer adding jdo file package.jdo.
[java] Enhancer adding class file InstanceLifecycleListenerClear$PC.class.
[java] Enhancer adding class file InstanceLifecycleListenerDelete$PC.class.
...
Also, in the original code all jdo files are listed before the class files, but
rearranging the order does not cause a failure.
> tck enhancement should make use of feature to enhance an entire directory
> -------------------------------------------------------------------------
>
> Key: JDO-639
> URL: https://issues.apache.org/jira/browse/JDO-639
> Project: JDO
> Issue Type: Improvement
> Components: tck2
> Affects Versions: JDO 2 maintenance release 2
> Reporter: Michael Bouschen
> Assignee: Michelle Caisse
> Attachments: enhance.txt
>
>
> The current enhancer call as part of the runtck goal takes a list of .jdo
> files as an argument (see property jdo.tck.jdometadata.files in
> project.properties and maven.xml). The new enhancer invocation API allows to
> enhance all files of a given directory. We should investigate to make use of
> this feature in order to get rid of listing all the .jdo in the property
> jdo.tck.jdometadata.files.
> There is a similar issue with the properties jdo.tck.pcclasses.sources and
> jdo.tck.pcclasses.files:
> - Property jdo.tck.pcclasses.sources is used when checking whether
> (re)enhancing is required. Maybe a pattern
> org/apache/jdo/tck/api/**/*.java, org/apache/jdo/tck/pc/**/*.java
> can be used instead of listing all the persistent capable classes explicitly.
> - Property jdo.tck.pcclasses.files is used when copying the class file into
> the identitytype specific subdirectories before running the enhancer. Maybe a
> similar pattern could replace the list of class files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
