[
https://issues.apache.org/jira/browse/JDO-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804336#action_12804336
]
Craig Russell commented on JDO-630:
-----------------------------------
Review during conference call:
comment regarding PartTimeEmployee is wrong; should be FullTimeEmployee
remove occurrences of system.out.println; replace with log.debug
testConcreteSuperclassExact test case is wrong; should expect exactly
Person.class not instanceof test; then should fail when any database access
(access to a non-id field) discovers wrong class
testWrongClass: message needs clarification
> Support specification of exact class in SingleFieldIdentity
> -----------------------------------------------------------
>
> Key: JDO-630
> URL: https://issues.apache.org/jira/browse/JDO-630
> Project: JDO
> Issue Type: Improvement
> Components: specification, tck2
> Reporter: Andy Jefferson
> Assignee: Craig Russell
> Fix For: JDO 2 maintenance release 3
>
> Attachments: jdo-630.patch
>
>
> When calling PersistenceManager.getObjectById() with a SingleFieldIdentity,
> there seems to be no way of avoiding the following
> (if the implementation decides to do so):
> "It is an implementation decision whether to access the data store, if
> required to determine the exact class. This will be the case of inheritance,
> where multiple <code>PersistenceCapable</code> classes share the same
> ObjectId class."
> Now when I know for sure that the targetClassName of the given
> SingleFieldIdentity already denotes the correct class for the given id, how
> can I avoid that additional roundtrip to the database for finding the exact
> class?
> It would be useful to have a way of specifying a SingleFieldIdentity to be
> for the exact class specified. This could be done by addition of methods
> void setExact(boolean flag);
> boolean getExact();
> to SingleFieldIdentity
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
