Refactored & attached patch. FYI, refactoring has spec ramifications. See https://issues.apache.org/jira/browse/JDO-696.
On Fri, Oct 14, 2011 at 2:42 PM, Craig L Russell <craig.russ...@oracle.com> wrote: > > On Oct 14, 2011, at 12:31 PM, Matthew Adams wrote: > >> On Fri, Oct 14, 2011 at 12:07 PM, Craig L Russell >> <craig.russ...@oracle.com> wrote: >>> >>> 3. Other issues >>> >>> https://issues.apache.org/jira/browse/JDO-696 applies to both JDOHelper >>> as >>> well as IUT if the PMF is constructed directly with a new >>> VendorPersistenceManagerFactory. Add api test case and tck test case for >>> IUT >>> case. >>> >>> Consider making private static void >>> assertOnlyKnownStandardProperties(Map<?, >>> ?> properties) public to allow IUT to use the method directly. >>> >> Actually, I think that this method might belong on JDOImplHelper. >> It's more of an SPI than an API, and I don't think an end user of >> JDOHelper would expect to see assertOnlyKnownStandardProperties. What >> do you say to moving it to JDOImplHelper and making it public there? > > Goo didea. > > Craig > > Craig L Russell > Architect, Oracle > http://db.apache.org/jdo > 408 276-5638 mailto:craig.russ...@oracle.com > P.S. A good JDO? O, Gasp! > > -- @matthewadams12 mailto:matt...@matthewadams.me skype:matthewadams12 yahoo:matthewadams aol:matthewadams12 google-talk:matthewadam...@gmail.com msn:matt...@matthewadams.me http://matthewadams.me http://www.linkedin.com/in/matthewadams
