Hi,
1. TCK query test failure: possible time zone issue in SupportedDateMethods:
https://issues.apache.org/jira/browse/JDO-720
AI Michelle try removing the time zone setting and see if that fixes the issue.
attached you find a patch file (TimeZoneChanges.patch) removing the time
zone setting. I can successfully run the TCK using the patch file.
Regards Michael
--
*Michael Bouschen*
*Prokurist*
akquinet tech@spree GmbH
Bülowstr. 66, D-10783 Berlin
Fon: +49 30 235 520-33
Fax: +49 30 217 520-12
Email: [email protected]
Web: www.akquinet.de <http://www.akquinet.de>
akquinet tech@spree GmbH, Berlin
Geschäftsführung: Martin Weber, Dr. Torsten Fink
Amtsgericht Berlin-Charlottenburg HRB 86780 B
USt.-Id. Nr.: DE 225 964 680
Index: tck/src/java/org/apache/jdo/tck/pc/company/CompanyModelReader.java
===================================================================
--- tck/src/java/org/apache/jdo/tck/pc/company/CompanyModelReader.java
(revision 1481529)
+++ tck/src/java/org/apache/jdo/tck/pc/company/CompanyModelReader.java
(working copy)
@@ -94,8 +94,7 @@
*/
private void configureFactory() {
SimpleDateFormat formatter = new SimpleDateFormat(DATE_PATTERN,
Locale.US);
- formatter.setTimeZone(TimeZone.getTimeZone("America/New_York"));
- CustomDateEditor dateEditor =
+ CustomDateEditor dateEditor =
new CustomDateEditor(formatter, true);
registerCustomEditor(Date.class, dateEditor);
companyFactory = CompanyFactoryRegistry.getInstance();
@@ -117,7 +116,7 @@
}
public static Date stringToUtilDate(String value) {
- return ConversionHelper.toUtilDate(DATE_PATTERN, "America/New_York",
Locale.US, value);
+ return ConversionHelper.toUtilDate(DATE_PATTERN, Locale.US, value);
}
// Convenience methods
Index:
tck/src/java/org/apache/jdo/tck/pc/companyListWithoutJoin/CompanyModelReader.java
===================================================================
---
tck/src/java/org/apache/jdo/tck/pc/companyListWithoutJoin/CompanyModelReader.java
(revision 1481529)
+++
tck/src/java/org/apache/jdo/tck/pc/companyListWithoutJoin/CompanyModelReader.java
(working copy)
@@ -94,8 +94,7 @@
*/
private void configureFactory() {
SimpleDateFormat formatter = new SimpleDateFormat(DATE_PATTERN,
Locale.US);
- formatter.setTimeZone(TimeZone.getTimeZone("America/New_York"));
- CustomDateEditor dateEditor =
+ CustomDateEditor dateEditor =
new CustomDateEditor(formatter, true);
registerCustomEditor(Date.class, dateEditor);
companyFactory = CompanyFactoryRegistry.getInstance();
@@ -191,7 +190,7 @@
}
public static Date stringToUtilDate(String value) {
- return ConversionHelper.toUtilDate(DATE_PATTERN, "America/New_York",
Locale.US, value);
+ return ConversionHelper.toUtilDate(DATE_PATTERN, Locale.US, value);
}
}
Index:
tck/src/java/org/apache/jdo/tck/pc/companyMapWithoutJoin/CompanyModelReader.java
===================================================================
---
tck/src/java/org/apache/jdo/tck/pc/companyMapWithoutJoin/CompanyModelReader.java
(revision 1481529)
+++
tck/src/java/org/apache/jdo/tck/pc/companyMapWithoutJoin/CompanyModelReader.java
(working copy)
@@ -94,8 +94,7 @@
*/
private void configureFactory() {
SimpleDateFormat formatter = new SimpleDateFormat(DATE_PATTERN,
Locale.US);
- formatter.setTimeZone(TimeZone.getTimeZone("America/New_York"));
- CustomDateEditor dateEditor =
+ CustomDateEditor dateEditor =
new CustomDateEditor(formatter, true);
registerCustomEditor(Date.class, dateEditor);
companyFactory = CompanyFactoryRegistry.getInstance();
@@ -191,7 +190,7 @@
}
public static Date stringToUtilDate(String value) {
- return ConversionHelper.toUtilDate(DATE_PATTERN, "America/New_York",
Locale.US, value);
+ return ConversionHelper.toUtilDate(DATE_PATTERN, Locale.US, value);
}
}
Index: tck/src/java/org/apache/jdo/tck/pc/order/OrderModelReader.java
===================================================================
--- tck/src/java/org/apache/jdo/tck/pc/order/OrderModelReader.java
(revision 1481529)
+++ tck/src/java/org/apache/jdo/tck/pc/order/OrderModelReader.java
(working copy)
@@ -94,8 +94,7 @@
private void configureFactory() {
SimpleDateFormat formatter =
new SimpleDateFormat(DATE_PATTERN, Locale.US);
- formatter.setTimeZone(TimeZone.getTimeZone("America/New_York"));
- CustomDateEditor dateEditor =
+ CustomDateEditor dateEditor =
new CustomDateEditor(formatter, true);
registerCustomEditor(Date.class, dateEditor);
orderFactory = OrderFactoryRegistry.getInstance();
@@ -143,8 +142,7 @@
}
public static Date stringToUtilDate(String value) {
- return ConversionHelper.toUtilDate(DATE_PATTERN, "America/New_York",
- Locale.US, value);
+ return ConversionHelper.toUtilDate(DATE_PATTERN, Locale.US, value);
}
}
Index: tck/src/java/org/apache/jdo/tck/pc/mylib/MylibReader.java
===================================================================
--- tck/src/java/org/apache/jdo/tck/pc/mylib/MylibReader.java (revision
1481529)
+++ tck/src/java/org/apache/jdo/tck/pc/mylib/MylibReader.java (working copy)
@@ -90,8 +90,7 @@
*/
private void configureFactory() {
SimpleDateFormat formatter = new SimpleDateFormat(DATE_PATTERN,
Locale.US);
- formatter.setTimeZone(TimeZone.getTimeZone("America/New_York"));
- CustomDateEditor dateEditor =
+ CustomDateEditor dateEditor =
new CustomDateEditor(formatter, true);
registerCustomEditor(Date.class, dateEditor);
}
Index:
tck/src/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenDateFieldsAndParameters.java
===================================================================
---
tck/src/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenDateFieldsAndParameters.java
(revision 1481529)
+++
tck/src/java/org/apache/jdo/tck/query/jdoql/operators/EqualityAndComparisonsBetweenDateFieldsAndParameters.java
(working copy)
@@ -117,8 +117,7 @@
private static final Date FIRST_OF_JAN_1999;
static {
// initialize static field FIRST_OF_JAN_1999
- Calendar cal = new GregorianCalendar(
- TimeZone.getTimeZone("America/New_York"));
+ Calendar cal = new GregorianCalendar();
cal.set(1999, GregorianCalendar.JANUARY, 1, 0, 0, 0);
cal.set(GregorianCalendar.MILLISECOND, 0);
FIRST_OF_JAN_1999 = cal.getTime();
Index:
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/NonCorrelatedSubqueries.java
===================================================================
---
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/NonCorrelatedSubqueries.java
(revision 1481529)
+++
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/NonCorrelatedSubqueries.java
(working copy)
@@ -111,8 +111,7 @@
"this.weeklyhours> (SELECT AVG(e.weeklyhours) FROM " +
Employee.class.getName() + " e)";
- Calendar cal = Calendar.getInstance(
- TimeZone.getTimeZone("America/New_York"), Locale.US);
+ Calendar cal = Calendar.getInstance(Locale.US);
cal.set(2002, Calendar.SEPTEMBER, 1, 0, 0, 0);
Date hired = cal.getTime();
Index:
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/CorrelatedSubqueriesWithParameters.java
===================================================================
---
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/CorrelatedSubqueriesWithParameters.java
(revision 1481529)
+++
tck/src/java/org/apache/jdo/tck/query/jdoql/subqueries/CorrelatedSubqueriesWithParameters.java
(working copy)
@@ -117,8 +117,7 @@
"(SELECT AVG(e.weeklyhours) FROM " + Employee.class.getName() +
" e WHERE e.manager == this.manager)";
- Calendar cal = Calendar.getInstance(
- TimeZone.getTimeZone("America/New_York"), Locale.US);
+ Calendar cal = Calendar.getInstance(Locale.US);
cal.set(2002, Calendar.SEPTEMBER, 1, 0, 0, 0);
Date hired = cal.getTime();
Index: tck/src/java/org/apache/jdo/tck/util/ConversionHelper.java
===================================================================
--- tck/src/java/org/apache/jdo/tck/util/ConversionHelper.java (revision
1481529)
+++ tck/src/java/org/apache/jdo/tck/util/ConversionHelper.java (working copy)
@@ -56,6 +56,15 @@
}
}
+ public static Date toUtilDate(String pattern, Locale locale, String value)
{
+ SimpleDateFormat formatter = new SimpleDateFormat(pattern, locale);
+ try {
+ return formatter.parse(value);
+ } catch (ParseException e) {
+ throw new JDOFatalException("", e);
+ }
+ }
+
/**
* Converts the given array into a {@link Map}.
* The first dimension represents the map entries,
