[
https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631944#comment-14631944
]
Craig L Russell commented on JDO-745:
-------------------------------------
The patch raises several questions for me.
Should we have negative tests for bitwise and and or for other unsupported
types?
Should we require bitwise and and or to be supported for integral types?
Should we have an assertion in the specification that the expression must be
boolean?
Should we add tck test cases for non-boolean expressions?
The patch includes an update for tck/src/conf/log4j.properties. Should the new
property be commented out?
> TCK BooleanLogicalAND, BooleanLogicalOR testNegative don't allow an
> implementation to provide an extension of bitwise AND/OR
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-745
> URL: https://issues.apache.org/jira/browse/JDO-745
> Project: JDO
> Issue Type: Bug
> Components: tck
> Reporter: Andy Jefferson
> Attachments: JDO-745.patch
>
>
> The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't
> test use of a boolean logical AND/OR. They actually test for an integer being
> used with the "&" and "|" operators. Sadly this means that any implementation
> that attempts to provide a vendor extension of support for bitwise AND/OR
> (for those RDBMS that support it) cannot pass the TCK.
> Perhaps add an "optional feature" for the vendor to support bitwise
> operations, and then don't run that test if so.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
