Hi Andy, > On Oct 9, 2017, at 6:03 AM, Andy Jefferson <notificati...@github.com> wrote: > > Thanks for the patch Craig, applied with a few minor changes. > > Comments : > > In future, a GitHub PullRequest would be more convenient (for me) since I can > directly apply it, and also GitHub provides a mechanism for adding comments
I am not such a git expert that I could easily figure out how to create a fork on github, annotate the patch, etc. etc. When I get to submitting another patch, I'll spend the time to figure it out. > I removed System.out, and added a LOG message for one of the usages. Cool > DN code conventions are > http://www.datanucleus.org/documentation/development.html#coding_standards > <http://www.datanucleus.org/documentation/development.html#coding_standards> > for future reference. I'm not quite as familiar with this style and my editor wasn't easily changed to the style. The "{ on a new line" messed up my indentation. Thanks for fixing it. > Now that you are merging the @PersistenceCapable annotation, at line 188 of > that file it currently checks for the main @PersistenceCapable annotation > being processed already and skips it, but if there are multiple then any > subsequent @PersistenceCapable will be processed. Yes? All of the processing of @PC happens in isClassPersistable which uses the AO[ ] that is prepared in the superclass. So at this point in the processing, the multiple @PC have been converted to AO and all are processed. By the way, the AbstractAnnotationReader getClassAnnotationsForClass method processes the class annotations and issues a warning if there are duplicates, but adds them anyway. I decided not to change that file, but was a bit confused about the warning since it no longer applies to the @PC annotation. The warning does apply to the other type-level annotations. I was thinking of having a Map<String, AnnotationObject> that would contain the name of the annotation as key and the default annotation object as value. Then the check at line 324 would also include !null == defaultAnnotationObjectMap.get(annName) to not issue the warning if it was a known duplicate-aware annotation. If you like I can put some energy into that. Craig > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/datanucleus/datanucleus-api-jdo/issues/65#issuecomment-335151509>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/APjPRLwckQuCyA0u_blw6gs6SJKlICgoks5sqhmYgaJpZM4Px6nS>. > Craig L Russell c...@apache.org
