tobous commented on a change in pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19#discussion_r567447688
##########
File path: pom.xml
##########
@@ -104,13 +104,22 @@
<goal>copy-resources</goal>
</goals>
<configuration>
- <outputDirectory>${basedir}/docs</outputDirectory>
- <resources>
- <resource>
- <directory>target/site</directory>
- </resource>
- </resources>
- </configuration>
+ <outputDirectory>${basedir}/docs</outputDirectory>
+ <nonFilteredFileExtensions>
+
<nonFilteredFileExtension>pdf</nonFilteredFileExtension>
+
<nonFilteredFileExtension>jar</nonFilteredFileExtension>
+
<nonFilteredFileExtension>html</nonFilteredFileExtension>
+ </nonFilteredFileExtensions>
+ <resources>
+ <resource>
+ <directory>target/site</directory>
+ </resource>
Review comment:
The output directory should be the configured build directory as the
deploy action just looks at the resources located in `target/site`.
Additionally, the previous configuration moving resources from `target/site`
is no longer necessary. It was previously used to move the build results into
the `docs` directory.
And, as a minor change, I don't think the filter exceptions are necessary as
filtering is explicitly disabled for the resource.
```suggestion
<outputDirectory>${build.dir}</outputDirectory>
<resources>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
