tobous commented on a change in pull request #33: URL: https://github.com/apache/db-jdo-site/pull/33#discussion_r584346496
########## File path: pom.xml ########## @@ -1,34 +1,57 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> - <groupId>org.apache.jdo.asciidoc</groupId> - <artifactId>jdo-asciidoc</artifactId> - <version>0.0.1-SNAPSHOT</version> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>23</version> + <relativePath></relativePath> + </parent> + + <groupId>org.apache.jdo</groupId> + <artifactId>jdo-site</artifactId> + <version>3.2-SNAPSHOT</version> <packaging>pom</packaging> - <name>Apache JDO Asciidoc</name> - <description>Apache JDO Asciidoc</description> - <url>http://www.apache.org/jdo</url> + + <name>Apache JDO Site</name> + <description>The Java Data Objects (JDO) API is a standard interface-based +Java model abstraction of persistence, developed as Java Specification +Requests (JSR 12 and 243) under the auspices of the Java Community Process. +This repository contains the sources for the Apache DB JDO website</description> + <url>http://db.apache.org/jdo</url> <inceptionYear>2019</inceptionYear> + <organization> + <name>Apache Software Foundation</name> + <url>http://www.apache.org</url> Review comment: ```suggestion <url>https://www.apache.org</url> ``` ########## File path: pom.xml ########## @@ -1,34 +1,57 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> - <groupId>org.apache.jdo.asciidoc</groupId> - <artifactId>jdo-asciidoc</artifactId> - <version>0.0.1-SNAPSHOT</version> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>23</version> + <relativePath></relativePath> + </parent> + + <groupId>org.apache.jdo</groupId> + <artifactId>jdo-site</artifactId> + <version>3.2-SNAPSHOT</version> <packaging>pom</packaging> - <name>Apache JDO Asciidoc</name> - <description>Apache JDO Asciidoc</description> - <url>http://www.apache.org/jdo</url> + + <name>Apache JDO Site</name> + <description>The Java Data Objects (JDO) API is a standard interface-based +Java model abstraction of persistence, developed as Java Specification +Requests (JSR 12 and 243) under the auspices of the Java Community Process. +This repository contains the sources for the Apache DB JDO website</description> + <url>http://db.apache.org/jdo</url> Review comment: ```suggestion <url>https://db.apache.org/jdo</url> ``` ########## File path: pom.xml ########## @@ -39,54 +62,14 @@ <groupId>org.asciidoctor</groupId> <artifactId>asciidoctor-maven-plugin</artifactId> <version>${asciidoctor.maven.plugin.version}</version> - <dependencies> - <dependency> - <groupId>org.asciidoctor</groupId> - <artifactId>asciidoctorj-pdf</artifactId> - <version>${asciidoctorj.pdf.version}</version> - </dependency> - <!-- Comment this section to use the default jruby artifact provided by the plugin --> - <dependency> - <groupId>org.jruby</groupId> - <artifactId>jruby-complete</artifactId> - <version>${jruby.version}</version> - </dependency> - <!-- Comment this section to use the default AsciidoctorJ artifact provided by the plugin --> - <dependency> - <groupId>org.asciidoctor</groupId> - <artifactId>asciidoctorj</artifactId> - <version>${asciidoctorj.version}</version> - </dependency> - <!-- dependency> - <groupId>org.asciidoctor</groupId> - <artifactId>asciidoctorj-diagram</artifactId> - <version>${asciidoctorj.diagram.version}</version> - </dependency--> - <!-- dependency> - <groupId>org.incode.asciidoctor.monotree</groupId> - <artifactId>incode-asciidoctor-extension-monotree</artifactId> - <version>${incode-asciidoctor-extension-monotree.version}</version> - </dependency--> - <!-- dependency> - <groupId>org.incode.asciidoctor.improvethisdoc</groupId> - <artifactId>incode-asciidoctor-extension-improvethisdoc</artifactId> - <version>${incode-asciidoctor-extension-improvethisdoc.version}</version> - </dependency--> - </dependencies> <configuration> - <!-- If you set baseDir to ${project.basedir}, top-level includes are resolved relative to the project root --> - <!-- <baseDir>${project.basedir}</baseDir> - --> <!-- Attributes common to all output formats --> <attributes> <endpoint-url>http://db.apache.org/jdo</endpoint-url> Review comment: ```suggestion <endpoint-url>https://db.apache.org/jdo</endpoint-url> ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
