Hi Brian,
On Fri, 2009-03-06 at 12:18 -0600, Brian Cameron wrote:
> #
> # spec file for package SUNWdbus-glib
> #
> # includes module(s): dbus_glib
nit: dbus-glib
> # Copyright 2008 Sun Microsystems, Inc.
2009
> Name: SUNWdbus-glib
> Summary: D-Bus GLib bindings
> Version: %{default_pkg_version}
Since this package contains just 1 upstream module, please use the
upstream version, not the default pkg version, so this should
be %{dbus_glib.version}
> %if %(test -f /usr/sadm/install/scripts/i.manifest && echo 0 || echo
> 1)
> %iclass manifest -f i.manifest
> %endif
This package doesn't ship an SMF manifest file, so this isn't needed.
> SUNWdbus-python
Make it SUNWdbus-python24 please.
> # includes module(s): dbus_python
dbus-python
> # Copyright 2008 Sun Microsystems, Inc.
2009
> Version: %{default_pkg_version}
%{dbus_python.version}
> %if %cc_is_gcc
> export EXTRA_CFLAGS="-I/usr/sfw/include"
> %else
> export EXTRA_CFLAGS="-xc99 -D_REENTRANT -I/usr/sfw/include
> -D__EXTENSIONS__"
> %endif
> export EXTRA_LDFLAGS="-L/usr/sfw/lib -R/usr/sfw/lib -lexpat"
I'm wondering if it really needs libexpat, or if dbus-glib needs
libexpat. Looks like these were just copied&pasted from the original
spec.
> export PYTHON=%{_bindir}/python
/usr/bin/python%{pythonver}
I wouldn't use %{_bindir} here, because %{_bindir} defines the
directory for the executables in *this* package. If this package
was moved to /usr/gnu/bin (just an example), python would still be
in /usr/bin.
> %if %(test -f /usr/sadm/install/scripts/i.manifest && echo 0 || echo
> 1)
> %iclass manifest -f i.manifest
> %endif
again, this is not needed
>
>
>
>
>
>
> plain text
> document
> attachment
> (SUNWdbus-python26.spec)
The same comments as for dbus-python.spec
Thanks,
Laca
