Hi Andras,
Thanks for the patch to fix doo 3402! Great! I need that for gnome-nettol :)
I do have a little query, in the bug you said
+diff -Naur libgtop-2.26.0.old/sysdeps/solaris/netlist.c
libgtop-2.26.0/sysdeps/solaris/netlist.c
+--- libgtop-2.26.0.old/sysdeps/solaris/netlist.c 2009-03-10
18:28:33.244136476 +0200
++++ libgtop-2.26.0/sysdeps/solaris/netlist.c 2009-03-10
18:30:13.828963197 +0200
+@@ -57,7 +57,7 @@
+
+ for (ksp = kc->kc_chain; ksp; ksp = ksp->ks_next)
+ {
+- if (strcmp(ksp->ks_class, "net") != 0)
++ if (strcmp(ksp->ks_module,"link") != 0)
+ continue;
+
Only this is required. But in the final patch you also have
+diff -Naur libgtop-2.26.0.old/sysdeps/solaris/netload.c
libgtop-2.26.0/sysdeps/solaris/netload.c
+--- libgtop-2.26.0.old/sysdeps/solaris/netload.c 2009-03-23
20:02:34.031743396 +0200
++++ libgtop-2.26.0/sysdeps/solaris/netload.c 2009-03-23
20:00:36.697284713 +0200
+@@ -182,7 +182,7 @@
+ /*
+ * chop off the trailing interface
+ */
+- module = strdup( name );
++ module = strdup( "link" );
+ ptr = module + strlen( module ) - 1;
+ while( (ptr > module) && isdigit( (int) *ptr ) ) {
+ *ptr = '\0';
+
Why is this one required?
I also don't it changed from a variable to a fixed string "link" in this
case.
Any better solution to this patch?
I am happy to integrate this into trunk.
-Ghee
On 03/24/09 06:32, Andras Barna wrote:
> add b.g.o bug number suggested by laca
>
> On Tue, Mar 24, 2009 at 7:44 AM, Andras Barna<andras.barna at gmail.com>
> wrote:
>
>> sorry, forgot patch comment
>>
>> On Tue, Mar 24, 2009 at 7:32 AM, Andras Barna<andras.barna at gmail.com>
>> wrote:
>>
>>> this should fix bug #3402
>>>
>>> thanks
>>>
>>> --
>>> Andy
>>> http://blog.sartek.net
>>>
>>>
>>
>> --
>> Andy
>> http://blog.sartek.net
>>
>>
>
>
>
>
