1. CR # 6601741 gedit: paste, cut, delete items in edit menu don't work for a read-only file
2. Product : JDS 3. Release : snv120 4. Changed Files base-specs/gedit.spec patches/gedit-03-clipboard-editability.diff Code Changes : Index: base-specs/gedit.spec =================================================================== --- base-specs/gedit.spec (revision 18686) +++ base-specs/gedit.spec (working copy) @@ -25,6 +25,8 @@ Patch1: gedit-01-menu-entry.diff # date:2008-12-26 owner:davelam type:bug bugzilla:581056 Patch2: gedit-02-py_ssize_t.diff +# date:2009-07-08 owner:an230044 type:bug bugzilla:6601741 +Patch3: gedit-03-clipboard-editability.diff URL: http://www.gnome.org BuildRoot: %{_tmppath}/%{name}-%{version}-build Docdir: %{_docdir}/doc @@ -74,6 +76,7 @@ %endif %patch1 -p1 %patch2 -p1 +%patch3 -p1 %build %ifos linux @@ -156,6 +159,8 @@ %{_libdir}/pkgconfig/* %changelog +* Wed Jul 08 2009 - abhijit.nath at sun.com +- Fixed Bug 6601741 * Fri Jul 03 2009 - yuntong.jin at sun.com - Bump to 2.26.3 * Mon Jun 08 2009 - brian.cameron at sun.com patches/gedit-03-clipboard-editability.diff ================================ --- gedit-2.26.3.orig/gedit/gedit-view.c 2009-07-08 12:39:39.441938100 +0530 +++ gedit-2.26.3/gedit/gedit-view.c 2009-07-08 12:46:28.261536300 +0530 @@ -523,9 +523,8 @@ gedit_view_cut_clipboard (GeditView *vie /* FIXME: what is default editability of a buffer? */ gtk_text_buffer_cut_clipboard (buffer, clipboard, - !gedit_document_get_readonly ( - GEDIT_DOCUMENT (buffer))); - + TRUE); /* Fix Bug 6601741 */ + gtk_text_view_scroll_to_mark (GTK_TEXT_VIEW (view), gtk_text_buffer_get_insert (buffer), GEDIT_VIEW_SCROLL_MARGIN, @@ -575,8 +574,7 @@ gedit_view_paste_clipboard (GeditView *v gtk_text_buffer_paste_clipboard (buffer, clipboard, NULL, - !gedit_document_get_readonly ( - GEDIT_DOCUMENT (buffer))); + TRUE); /* Fix Bug 6601741 */ gtk_text_view_scroll_to_mark (GTK_TEXT_VIEW (view), gtk_text_buffer_get_insert (buffer), @@ -608,9 +606,8 @@ gedit_view_delete_selection (GeditView * /* FIXME: what is default editability of a buffer? */ gtk_text_buffer_delete_selection (buffer, TRUE, - !gedit_document_get_readonly ( - GEDIT_DOCUMENT (buffer))); - + TRUE); /* Fix Bug 6601741 */ + gtk_text_view_scroll_to_mark (GTK_TEXT_VIEW (view), gtk_text_buffer_get_insert (buffer), GEDIT_VIEW_SCROLL_MARGIN, 5. Description of Changes Analysis and Solution : Readonly mode should not prevent users from cut/paste/delete. So changes made in the call of gtk clipboard api gtk_text_buffer_paste_clipboard (). 6. Code Changes: See File - /net/drosera.india/export/users/an230044/6601741/PKGS Path to Workspace - /net/drosera.india/export/users/an230044/6601741 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20090708/aac07f29/attachment.html>
