On Mon, Sep 15, 2008 at 2:12 AM, Laszlo (Laca) Peter
<Laszlo.Peter at sun.com> wrote:
> Hmmm... it sounds like JH_ADD_CFLAG is wrong, then. If it causes
> an error during compilation but not in configure, then the macro
> in configure is doing something differently. If you fix the macro,
> I'm sure it will be accepted upstream.
>
> Laca
Hi!
Okay,
It looks like we dont need the patch to fix the incompatible cflags.
SUNWdbus-bindings compiles fine with just Patch2 and Diff1. Apparently
the compile broke cause of an error with the python headers not being
able to be found on my system yesterday.
So if you are allright with it I'd like to introduce the following two
changes. Later on I will see how we can get rid of the illegal
compiler flag warnings in the log files but as this is merely cosmetic
and rather focus on broken functionality/broken compiles I rather
first go further with compiling the JDS stack.
Please approve or reject the following patches:
Index: base-specs/dbus-python.spec
===================================================================
--- base-specs/dbus-python.spec (revision 15408)
+++ base-specs/dbus-python.spec (working copy)
@@ -24,6 +24,7 @@
Docdir: %{_defaultdocdir}/doc
Autoreqprov: on
Prereq: /sbin/ldconfig
+Patch1: dbuspython-01-fix-wrong-python25-includes.diff
%define python_version 2.4
BuildRequires: glib2-devel >= %glib2_version
@@ -46,12 +47,13 @@
%prep
%setup -q
+%patch1 -p1
%build
aclocal $ACLOCAL_FLAGS -I ./m4
autoconf
automake -a -c -f
-export CFLAGS="%optflags -D_REENTRANT"
+export CFLAGS="%optflags -D_REENTRANT -I/usr/include/python2.4"
export LDFLAGS="%_ldflags"
./configure --prefix=%{_prefix} \
--includedir=%{_includedir}
$ cat patches/dbuspython-01-fix-wrong-python25-includes.diff
--- dbus-python-0.83.0/configure.ac.old 2008-09-14 16:57:13.605507082 +0200
+++ dbus-python-0.83.0/configure.ac 2008-09-14 16:58:50.623426362 +0200
@@ -44,12 +44,10 @@
AC_PROG_LIBTOOL
AM_PATH_PYTHON(2.4.0)
-AM_CHECK_PYTHON_HEADERS(,[AC_MSG_ERROR(could not find Python headers)])
-
PLATFORM=`$PYTHON -c "from distutils import util; print util.get_platform()"`
AC_SUBST(PLATFORM)
dnl Building documentation
--
Patrick
