Joe, This looks good. A few comments below:
> +License: Xiph Is this really planner's license? Our tracking web page, the OSR and your .copyright file all say GPL v2. > +Source: http://downloads.us.xiph.org/releases/%{name}/%{name}-%{version}.tar.bz2 I cannot access this URL - can you check it? I did find the sources at: http://ftp.gnome.org/pub/GNOME/sources/planner/0.14/ > +Patch1: planner-01-acinclude.m4.diff > +Patch2: planner-02-Makefile.am.diff > +Patch3: planner-03-Makefile.am.diff Each patch declaration should be preceded by a line describing the patch, eg # date:2008-09-17 owner:jat type:bug bugster:??????? see: http://opensolaris.org/os/project/jds/documents/patch_comments/ > +2008-09-16 Joseph A Townsend <set EMAIL_ADDRESS environment variable> Don't forget to fix EMAIL_ADDRESS before you commit. > +# %dir %attr (0755, root, root) %{_datadir}/mime/application > +# %attr(644,root,root) %{_datadir}/mime/application/x-planner.xml If these lines are not needed, please delete them. Also, we have a new process for setting up the copyright details in our open source pkgs: http://jdswiki.ireland.sun.com/twiki/bin/view/JDS/NewCopyright But please go ahead and commit your latest version first, and if you have problems with the new copyright process, let me know and I'll take a look at it. - Dermot btw - this review is non-blocking. You can commit your changes immediately, as long as you subsequently fix any reasonable issues brought up during the review. Joseph A Townsend wrote: > Please see attached the svn diff for the putback for planner. > I would like to catch build 100 tomorrow. > > Thanks in advance > > Joe Townsend >
