Hey all,
On Mon, 2008-10-13 at 11:05 +1300, Laszlo (Laca) Peter wrote:
> On Mon, 2008-10-13 at 10:50 +1300, Laszlo (Laca) Peter wrote:
> > > > http://dlc.sun.com/osol/jds/downloads/extras/time-slider/zfs-snapshot-0.11.1.tar.bz2
> > > >
> > > >
> > > > Looks like it's missing the .hg directory in the build area, which means
> > > > the hg command to tag the method script with the changeset fails.
> > > >
> > > > Any chance of putting it back so the build generates correctly tagged
> > > > packages? Not a huge deal, but'd make it a lot easier to support this
> > > > once it makes it out into the wild...
>
> Actually, Glynn has just pointed out on IRC that this is wrong,
> tagging should happen during "make dist" i.e. when you create the
> tarball and not during the build.
Just following up on this, the current tip changeset (79317ca73ba7) at:
ssh://timf at hg.opensolaris.org/hg/jds/zfs-snapshot
now does the right thing wrt. tagging during make dist.
It still also tries to tag during a build, but if you're building from
an extracted dist tarball, this will be a no-op (the sed expression
won't find any matches) and it'll leave the tag that was generated
during the "make dist" in place.
- my reasoning for this was so that if someone builds out of their own
hg workspace, they still get a tagged method script.
cheers,
tim
