Brian,
Looks good. One minor comment (unrelated to your changes really):
On Mon, 2008-05-05 at 19:00 -0500, Brian Cameron wrote:
> -export CFLAGS="%optflags -I/usr/sfw/include -DANSICPP"
> -export PKG_CONFIG_PATH=%{_builddir}/%name-%
> version/libogg-%{libogg.version}:%{_pkg_config_path}
> -export RPM_OPT_FLAGS="$CFLAGS"
> -export ACLOCAL_FLAGS="-I %{_datadir}/aclocal"
> export PERL5LIB=%{_prefix}/perl5/site_perl/5.6.1/sun4-solaris-64int
> -export LDFLAGS="%_ldflags"
PERL5LIB isn't needed either. We needed this env variable in
S10 because we installed some perl modules in the wrong location.
This line is getting copied and pasted into various spec files
ever since, but it's not needed at all.
If anyone finds them in spec files, please delete them.
Thanks,
Laca
