No, in the gtkstatusicon, it bundled the button 3 with popup signal and
button1 with activate signal.

I just updated my patch to fix the menu placement problem while using
keyboard (see attached).

Chris

Evan Yan ??:
> Will it make them the same behavior for both of clicking with left
> button and clicking with right button?
>
> Besides, it looks like a pretty good one to upstream.
>
> -Evan
>
> C Wang wrote:
>   
>> The root cause of the bug is in the pop-up signal callback function it
>> use if statement to filter the button
>> pressed.
>> if (button == 3):
>> self.__menu.popup(None, None, None, button, time)
>> This will filter all keyboard event, which is 0.
>>
>> Actually, the if statement is not necessary, as the gstatusicon has
>> already done this work. to fix the problem, we only need to remove the
>> if statement.
>>
>>
>>   
>>     

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gdesklets-05-shift-f10.diff
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080512/8c00f93e/attachment.ksh>

Reply via email to